[ENH] Add name_id_map parameter to add_orientations and enable serialization validation #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
Leguark
changed the title
name_id_map support in orientation data manipulation
4 tasks
Graphite Automations"Add gempy label" took an action on this PR • (09/25/25)1 label was added to this PR based on Miguel de la Varga's automation. |
Leguark
force-pushed
the
changes_for_server_I
branch
from
0d7c62b to
b194a5e
Compare
Leguark
force-pushed
the
serialize_hecho
branch
2 times, most recently
from
6348004 to
45ce60e
Compare
Leguark
force-pushed
the
changes_for_server_I
branch
from
b194a5e to
0554b52
Compare
Merge activity
|
Leguark
force-pushed
the
changes_for_server_I
branch
2 times, most recently
from
2dea909 to
e3cd247
Compare
Leguark
changed the base branch from
changes_for_server_I
to
graphite-base/1060
Integrated optional `name_id_map` parameter to the `add_orientation` method for mapping orientation names to IDs. Updated Hecho example with serialization validation and added save/load functionality for models.
Leguark
force-pushed
the
serialize_hecho
branch
from
45ce60e to
d2db5c0
Compare
…ncing validation Removed redundant save/load and serialization validation in the Hecho example. Adjusted section grid to ensure consistent tuple formatting and enabled `validate_serialization` in model computation.
Leguark
force-pushed
the
serialize_hecho
branch
from
d2db5c0 to
fd5675f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for name_id_map parameter in add_orientations function to maintain consistent ID mapping between surface points and orientations. Updated the Hecho example to use this parameter and fixed tuple formatting in section_dict. Also enabled validation during serialization in the compute_model call.
Relates to #validation-and-serialization-improvements
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).